#!/bin/bash
# portcfg-autocalc.sh
# Diagnose + suggest corrected internalportcfg / usbportcfg / esataportcfg.
#
# Principle (IMPORTANT): internalportcfg must RESERVE the full SATA port range
# (including empty slots, so future disks are auto-internal). So we do NOT
# rebuild it from scratch by OR-ing present disks. Instead we KEEP the current
# masks and only MOVE the bit of any disk whose physical channel disagrees with
# its current portcfg classification (e.g. a USB disk sitting at an internal index).
#
# Ground truth = physical channel from sysfs:
#   path contains "usb" -> should be usb
#   path contains "ata" -> should be internal (or esata if you list it below)
set -u

# ---- config: list eSATA disk indices here (space separated), if any ----
ESATA_INDICES=""

get_cfg() {
  grep -iE "^$1=" /etc/synoinfo.conf 2>/dev/null | head -1 \
    | sed -E 's/.*="?0x([0-9A-Fa-f]+)"?.*/\1/I'
}
INT=$(get_cfg internalportcfg); USB=$(get_cfg usbportcfg); ESA=$(get_cfg esataportcfg)
INTV=$((16#$INT)); USBV=$((16#$USB)); ESAV=$((16#$ESA))
nINT=$INTV; nUSB=$USBV; nESA=$ESAV   # working copies we will adjust

is_esata_idx() { [ -n "$ESATA_INDICES" ] && echo " $ESATA_INDICES " | grep -q " $1 "; }

class_of_bit() {
  local b=$1
  if   (( USBV & (1<<b) )); then echo usb
  elif (( ESAV & (1<<b) )); then echo esata
  elif (( INTV & (1<<b) )); then echo internal
  else echo none; fi
}

printf "%-5s %-4s %-5s | %-10s %-10s | %s\n" DEV IDX CHAN CUR_CLASS EXPECT STATUS
echo "-----+----+------+----------+----------+------------------"
moves=""
for d in /run/synostorage/disks/*; do
  [ -e "$d" ] || continue
  dev=$(basename "$d"); id=$(cat "$d/id" 2>/dev/null); [ -z "$id" ] && continue
  p=$(readlink -f "/sys/block/$dev/device" 2>/dev/null)
  case "$p" in
    *usb*) ch="usb"; exp="usb" ;;
    *ata*) ch="ata"; if is_esata_idx "$id"; then exp="esata"; else exp="internal"; fi ;;
    *)     ch="?";   exp="?" ;;
  esac
  b=$((id-1))   # 1-based
  cur=$(class_of_bit $b)
  if [ "$cur" = "$exp" ]; then st="ok"; else
    st="MISMATCH -> move bit$b to $exp"
    # remove this bit from all three working masks, then set it in the expected one
    nINT=$(( nINT & ~(1<<b) )); nUSB=$(( nUSB & ~(1<<b) )); nESA=$(( nESA & ~(1<<b) ))
    case "$exp" in
      internal) nINT=$(( nINT | (1<<b) )) ;;
      usb)      nUSB=$(( nUSB | (1<<b) )) ;;
      esata)    nESA=$(( nESA | (1<<b) )) ;;
    esac
    moves="$moves\n  $dev (idx=$id, chan=$ch): bit$b $cur -> $exp"
  fi
  printf "%-5s %-4s %-5s | %-10s %-10s | %s\n" "$dev" "$id" "$ch" "$cur" "$exp" "$st"
done
echo
echo "=== masks ==="
printf "current  internalportcfg = 0x%08X\n" "$INTV"
printf "current  usbportcfg      = 0x%08X\n" "$USBV"
printf "current  esataportcfg     = 0x%08X\n" "$ESAV"
echo
printf "suggested internalportcfg = 0x%08X\n" "$nINT"
printf "suggested usbportcfg      = 0x%08X\n" "$nUSB"
printf "suggested esataportcfg    = 0x%08X\n" "$nESA"
echo
if [ -n "$moves" ]; then
  echo "=== changes (bit moves) ==="
  echo -e "$moves"
  echo
  echo "Apply: edit user-config.yml on /dev/synoboot1 with the suggested masks,"
  echo "       recompile the RR loader, reboot. (See portcfg-guide.md.)"
else
  echo "No mismatch found. Current masks agree with physical channels -> nothing to change."
fi

#!/bin/bash
# Verify whether portcfg is 1-based (bit N-1 = disk N) or 0-based (bit N = disk N)
# Ground truth = physical channel from sysfs (usb->expect usb; ata->expect internal/esata).
# Only "distinguishing" disks (where the two interpretations give different classes) are decisive.
set -u

get_cfg() {
  grep -iE "^$1=" /etc/synoinfo.conf 2>/dev/null | head -1 \
    | sed -E 's/.*="?0x([0-9A-Fa-f]+)"?.*/\1/I'
}
INT=$(get_cfg internalportcfg); USB=$(get_cfg usbportcfg); ESA=$(get_cfg esataportcfg)
INTV=$((16#$INT)); USBV=$((16#$USB)); ESAV=$((16#$ESA))

echo "internalportcfg = 0x$INT"
echo "usbportcfg      = 0x$USB"
echo "esataportcfg    = 0x$ESA"
echo

class_of_bit() {
  local b=$1
  if   (( USBV & (1<<b) )); then echo usb
  elif (( ESAV & (1<<b) )); then echo esata
  elif (( INTV & (1<<b) )); then echo internal
  else echo none; fi
}

printf "%-5s %-4s %-5s | %-16s %-16s | %s\n" DEV IDX CHAN "1-based(bitN-1)" "0-based(bitN)" DISTINGUISH
echo "-----+----+------+------------------+------------------+-----------"
m1=0; m0=0; nd=0
for d in /run/synostorage/disks/*; do
  [ -e "$d" ] || continue
  dev=$(basename "$d"); id=$(cat "$d/id" 2>/dev/null); [ -z "$id" ] && continue
  p=$(readlink -f "/sys/block/$dev/device" 2>/dev/null)
  case "$p" in
    *usb*) ch="usb"; exp=usb ;;
    *ata*) ch="ata"; exp="int/esata" ;;
    *)     ch="?";   exp="?" ;;
  esac
  b1=$((id-1)); b0=$id
  c1=$(class_of_bit $b1); c0=$(class_of_bit $b0)
  if [ "$c1" = "$c0" ]; then dif="no"; else dif="YES <--key"; nd=$((nd+1)); fi
  printf "%-5s %-4s %-5s | %-16s %-16s | %s\n" "$dev" "$id" "$ch" "$c1(bit$b1)" "$c0(bit$b0)" "$dif"
done
echo
echo "=== Verdict from distinguishing disks ==="
if [ "$nd" -eq 0 ]; then
  echo "No distinguishing disk found (both interpretations agree on every disk)."
  echo "Cannot decide base; need a disk whose bit(N-1) and bitN fall in different cfgs."
  exit 0
fi
for d in /run/synostorage/disks/*; do
  [ -e "$d" ] || continue
  dev=$(basename "$d"); id=$(cat "$d/id" 2>/dev/null); [ -z "$id" ] && continue
  p=$(readlink -f "/sys/block/$dev/device" 2>/dev/null)
  case "$p" in *usb*) ch=usb;; *ata*) ch=ata;; *) ch=?;; esac
  b1=$((id-1)); b0=$id
  c1=$(class_of_bit $b1); c0=$(class_of_bit $b0)
  [ "$c1" = "$c0" ] && continue
  case "$ch" in
    usb) ok1=$([ "$c1" = usb ] && echo match || echo MISMATCH); ok0=$([ "$c0" = usb ] && echo match || echo MISMATCH) ;;
    ata) ok1=$({ [ "$c1" = internal ]||[ "$c1" = esata ];} && echo match || echo MISMATCH); ok0=$({ [ "$c0" = internal ]||[ "$c0" = esata ];} && echo match || echo MISMATCH) ;;
    *) ok1=unknown; ok0=unknown ;;
  esac
  [ "$ok1" = match ] && m1=$((m1+1))
  [ "$ok0" = match ] && m0=$((m0+1))
  echo "$dev: idx=$id chan=$ch | 1-based->$c1($ok1)  0-based->$c0($ok0)"
done
echo
echo "Distinguishing-disk tally: 1-based matches=$m1, 0-based matches=$m0"
if   [ "$m1" -gt "$m0" ]; then echo "CONCLUSION: portcfg is 1-based (bit N-1 = disk index N)"
elif [ "$m0" -gt "$m1" ]; then echo "CONCLUSION: portcfg is 0-based (bit N = disk index N)"
else echo "CONCLUSION: tie or undecided (check the table for misconfigured disks)"; fi